Conversation
|
Still WIP. @amoeba I did some potentially sketchy stuff with Pydantic. |
|
Looks pretty reasonable to me. What did you feel was sketchy with pydantic? |
|
I had to fight it quite a bit to express the semantics I wanted here, maybe I'm just not used to its vocabulary |
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
Looks good. I pushed up a minor QoL improvement which errors out earlier during the workflow gen process: amoeba@23dbd65.
We could consider caching Rust stuff in CI so speed up builds but it's not critical today I don't think.
lidavidm
force-pushed
the
dev
branch
5 times, most recently
from
98c036e to
0a59feb
Compare
| - { platform: linux, arch: amd64, runner: ubuntu-latest } | ||
| - { platform: macos, arch: arm64, runner: macos-latest } | ||
| - { platform: win, arch: amd64, runner: windows-latest } | ||
| - { platform: windows, arch: amd64, runner: windows-latest } |
There was a problem hiding this comment.
Make this consistent with below
| - name: Test | ||
| if: runner.os != 'Linux' | ||
| working-directory: go | ||
| run: | | ||
| go test -tags assert -v ./... | ||
|
|
There was a problem hiding this comment.
Some configs may need to be updated to skip tests when not on Linux since now we run the pre-test stuff for all platforms
2 participants
What's Changed
Generalizes the Go workflow for Rust.