fix: minor issues with go_mod_path construction and use#145
Merged
lidavidm merged 3 commits intoadbc-drivers:mainfrom Apr 14, 2026
Merged
fix: minor issues with go_mod_path construction and use#145lidavidm merged 3 commits intoadbc-drivers:mainfrom
lidavidm merged 3 commits intoadbc-drivers:mainfrom
Conversation
Contributor
|
Note that pre-commit is failing |
Contributor
Author
|
Pre-commit is fixed. Re-requested review since I can't merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Fixes two minor things with go_mod_path. Without this, the generated
dev.yamlwill use a hard codedgo/go.modpath. I missed this in aa2b3ac. The other thing is just a minor safety thing, thatgo_mod_pathdidn't have a default.Tested locally with a test repo: