Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlStore: use bytes instead of str for url paths #88

Merged
merged 9 commits into from
May 30, 2024
Merged

Conversation

adbar
Copy link
Owner

@adbar adbar commented Mar 18, 2024

No description provided.

@adbar adbar marked this pull request as draft March 18, 2024 11:35
tests/urlstore_tests.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (720ccbb) to head (8932aa0).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          818       820    +2     
=========================================
+ Hits           818       820    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar adbar changed the title UrlStore: use bytes in keys UrlStore: use bytes instead of str Mar 19, 2024
@adbar adbar marked this pull request as ready for review May 29, 2024 17:11
@adbar adbar changed the title UrlStore: use bytes instead of str UrlStore: use bytes instead of str for url paths May 29, 2024
@adbar adbar merged commit 9ac3d3c into master May 30, 2024
14 checks passed
@adbar adbar deleted the keys_as_bytes branch May 30, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant