mypy: deal with urllib3

adbar · Mar 7, 2023 · 23e415c · 23e415c
1 parent 4b3d789
commit 23e415c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -75,7 +75,7 @@ jobs:
     - name: Type checking with mypy
       if: ${{ matrix.python-version != 'pypy3.8' }}
       run: |
-        python -m pip install --upgrade mypy
+        python -m pip install --upgrade mypy types-urllib3
         mypy -p courlan
 
     - name: Test with pytest

diff --git a/courlan/network.py b/courlan/network.py
@@ -7,7 +7,7 @@
 
 import logging
 
-import urllib3  # type: ignore
+import urllib3
 
 
 LOGGER = logging.getLogger(__name__)
@@ -38,7 +38,7 @@ def redirection_test(url: str) -> str:
     #    "User-Agent" : str(sample(settings.USER_AGENTS, 1)), # select a random user agent
     # })
     try:
-        rhead = HTTP_POOL.request("HEAD", url)
+        rhead = HTTP_POOL.request("HEAD", url)  # type:ignore[no-untyped-call]
     except Exception as err:
         LOGGER.exception("unknown error: %s %s", url, err)
     else: