Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
Fix
aria-labelto the YouTube<iframe>, taken from the component'sdisplayTitle(falling back totitle).Notes
Previously the iframe had no author-set accessible name. The only name was a
titleattribute injected at runtime by the YouTube widget API, set to the video's own YouTube title, which authors cannot control or localise. The newaria-labeltakes precedence in the accessible name computation, so screen readers announce the component's title instead.Per the discussion on #22,
aria-labelis used rather thantitle(astitlebehaves inconsistently on iframes). This mirrors the approach already used in adapt-contrib-media (adaptlearning/adapt_framework#2822). Relevant WCAG success criterion: 4.1.2 Name, Role, Value (technique H64).The label is only emitted when
displayTitleortitleis set, so no emptyaria-label=""is produced.Testing
displayTitleset.<iframe>inside.youtube__widget.aria-labelmatching the component'sdisplayTitle.Posted via collaboration with Claude Code