Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appointment.views: some improvements #166

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

deronnax
Copy link
Collaborator

@deronnax deronnax commented Mar 29, 2024

  • the staff_member of the form mandatorily exist (the form guarantees it through it is_valid method), so the whole if not block can be removed
  • a None variable and an empty string are both falsy in Python, you can check for both in the same time with just if xxx

@deronnax deronnax self-assigned this Mar 29, 2024
@deronnax deronnax marked this pull request as draft March 29, 2024 23:03
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (db269f3) to head (0df4d22).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   95.33%   95.34%   +0.01%     
==========================================
  Files          50       50              
  Lines        5784     5779       -5     
==========================================
- Hits         5514     5510       -4     
+ Misses        270      269       -1     
Flag Coverage Δ
unittests 95.34% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant