forked from chirag04/react-native-mail
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy attachments as temporary files before sending #6
Open
adamski
wants to merge
17
commits into
master
Choose a base branch
from
temp-file-attachments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ae39a8d
Rebase mult-attachment PR
adamski 4a02c4d
Add iOS audio MIME types
adamski ecfd0a3
Fix multimple attachments android
kneza23 bea7cd4
Merge pull request #1 from kneza23/multiple-attachments-fix
adamski 0128cb3
Revert "Fix multimple attachments android"
adamski 04917f9
Merge pull request #2 from adamski/revert-1-multiple-attachments-fix
adamski 0366525
Revert "Revert "Fix multimple attachments android""
adamski 77fa8de
Merge branch 'master' into revert-2-revert-1-multiple-attachments-fix
adamski 5881937
Merge pull request #3 from adamski/revert-2-revert-1-multiple-attachm…
adamski e85c526
Fixed a syntax error in RNMailModule.
timscott 9c75f26
Merge pull request #4 from timscott/fix-syntax-error
adamski ac92e5d
Fixed various issue in android with multiple attachments.
timscott 4373988
Merge pull request #5 from timscott/fix-android-issues
adamski 35e958a
Update README for multiple attachments update
adamski c32ed75
Fix bracket order typo
adamski e79eb57
Copy attachments as temporary files before sending
adamski a4a7291
Add missing file copy method
adamski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,11 +125,11 @@ export default class App extends Component { | |
bccRecipients: ['[email protected]'], | ||
body: '<b>A Bold Body</b>', | ||
isHTML: true, | ||
attachment: { | ||
attachments: [{ | ||
path: '', // The absolute path of the file from which to read data. | ||
type: '', // Mime Type: jpg, png, doc, ppt, html, pdf | ||
name: '', // Optional: Custom filename for attachment | ||
} | ||
}] | ||
}, (error, event) => { | ||
Alert.alert( | ||
error, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably fail here as temporaryFile will be null