Skip to content

Fix validation for postgresql+psycopg2 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix validation for postgresql+psycopg2 #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef13d80
Fixed validation for postgresql+psycopg2
tonjo Apr 16, 2024
24edc4d
Merge pull request #1 from tonjo/tonjo-patch-1
tonjo Apr 16, 2024
c5299be
Merge branch 'adamhmetal:main' into main
tonjo Apr 17, 2024
68ff17f
psycogp2 support
tonjo Apr 17, 2024
c712427
Remove .vscode files
tonjo Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"workbench.colorCustomizations": {
"activityBar.background": "#442520",
"titleBar.activeBackground": "#5F342D",
"titleBar.activeForeground": "#FCF9F9"
}
}
1 change: 1 addition & 0 deletions tests/run_compatibility_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"legacy (2022)": [
"SQLAlchemy==2.0.0",
"psycopg==3.0.18",
"psycopg2==2.9.9",
Copy link
Owner

@adamhmetal adamhmetal Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortanatelly it will not be enough
It will fulfill tests but not because it works.
In fact works because is already psycopg installed in base file
if you remove psycopg you will observe crash.

You can check the way I suggested:


PACKAGES_VERSIONS = {
    (...)
    "psycopg2 (2024)": [
        "SQLAlchemy==2.0.0",
        "psycopg2==2.9.9",
        "PyMySQL==1.0.2",
        "alembic==1.8.0",
        "psycopg==None",
    ],
}


                (...)
                for package_version, packages in PACKAGES_VERSIONS.items():
                    install_dependencies_command = ""
                    for package in packages:
                        if package.endswith("==None"):
                            install_dependencies_command += f"poetry remove {package.split('==')[0]} &&"
                        else:
                            install_dependencies_command += f"poetry add {package} &&"

then you will observe failure, as psycopg2 is not used in such case.

It will need a little more work to make it stable.

"PyMySQL==1.0.2",
"alembic==1.8.0",
],
Expand Down