Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract conventions #29 #31

Closed
wants to merge 2 commits into from
Closed

Conversation

desirablecoder
Copy link
Collaborator

abstract conventions #29

this is how i intended to implement method chaining to facilitate configuration based model mapping.
ModelMapAttribute.cs - an attribute for Configuration based model mapping.
IdentityAttribute.cs - its just a duplicate attribute. it will be moved to AO.Model.IdentityAttribute eventually.
@adamfoneil
Copy link
Owner

@desirablecoder just to note what we chatted about, #30 should be the test case for this. I'd like to see some kind of integration test as part of this that builds and diffs a couple of simple models, somewhat like this:

var aoBuilder = new ModelBuilder<AOModelBuilder>();
var model1 = aoBuilder.Build(Source.Dll, "some dll");
var model2 = aoBuilder.Build(Source.Database, "some connection string");
var diffs = DataModel.Compare(model1, model2);

@adamfoneil
Copy link
Owner

@desirablecoder I think this doesn't align well with #29 , but I know I've waffled quite a bit on requirements

@adamfoneil adamfoneil closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants