Fix ASGI compatibliity on Python 3.12 #911
Conversation
|
Did this fix the issue for you? Please also add a changelog note and include the |
|
Yes, this did fix the issue. I added a changelog note, but I'm not sure how to update the tests to get 100% coverage, also should I be adding the |
for more information, see https://pre-commit.ci
|
For the test coverage issue, have a look at the HTML coverage report in the artifacts section: https://github.com/adamchainz/django-cors-headers/actions/runs/6805112094?pr=911
So basically there is a test missing for the else branch there. |
src/corsheaders/middleware.py
Outdated
| result = self.get_response(request) | ||
| assert not isinstance(result, HttpResponseBase) | ||
| response = await result |
There was a problem hiding this comment.
This section did not need changing. The change lead to insufficient test coverage.
It doesn't need changing because when __acall__ is called, we know we're in async mode, and that get_response will return a coroutine. Mypy just doesn't know that, hence the type-narrowing assert
|
Alright, I recreated the bug with an example project and have verified this fix works. Thank you both. |
|
Released in 4.3.1. |
From issue #908, changed middleware.py to reflect the changes made in adamchainz/django-htmx#381 as they had similar issues.