Implement GATT for Zephyr _bleio - #11179
Merged
Merged
Conversation
Merged
Collaborator
Tested with BSIM and on nRF54LM20DK. CharacteristicBuffer and PacketBuffer are implemented as well. This hasn't been tested for BLE workflow so it may need allocation tweaks. Includes many other small fixes: * bsim tests are done with nRF54LM20bsim too. * bsim exe binaries are saved. * nRF7002DK loses bleio because it doesn't have space. * Other boards have their slot1 removed in favor of slot0 growing. * Fix UUID length and byte order issues. * Remove extra common_hal function for remote services. Code gen by DeepSeek V4 Pro. All prompted and reviewed by me. This is a bunch of work towards micropython#9904, implementing _bleio. Pairing and bonding remains.
Member
Author
|
Ok, I rebased this on top of the extmod stuff to remove the autogen changes here. |
Member
Author
|
CI is green! |
dhalbert
reviewed
Aug 7, 2026
dhalbert
left a comment
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
Looks nice and clean, maybe due to good Zephyr API as well.
There are a bunch of printk()s in the code; did you mean to leave them in?
Member
Author
|
I see them mostly in the sample code used in the tests. Generally, I'm not too worried about it because the port is very much in flux still. I'm ok cleaning them up later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with BSIM and on nRF54LM20DK. CharacteristicBuffer and PacketBuffer are implemented as well. This hasn't been tested for BLE workflow so it may need allocation tweaks.
Includes many other small fixes:
Code gen by DeepSeek V4 Pro. All prompted and reviewed by me.
This is a bunch of work towards #9904, implementing
_bleio. Pairing and bonding remains.