Skip to content

restore mpy-cross STATIC_BUILD checking #10388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

dhalbert
Copy link
Collaborator

-- Fixes #10387.

mpy-cross STATIC_BUILD flag checking from #1013 and #2551 was lost in #8481. Restore it.

I'll check the artifacts after they're built.

@dhalbert
Copy link
Collaborator Author

dhalbert commented May 30, 2025

I tested the Windows executable and the Linux excutable, and they work. ldd said not a dynamic executable, as hoped. The user who was on an older Linux said the new build worked for them. The macOS builds do not deal with STATIC_BUILD, but they are working as well.

@dhalbert dhalbert requested a review from eightycc May 30, 2025 14:55
@eightycc
Copy link
Collaborator

Thank you!

@eightycc eightycc merged commit 670fbb0 into adafruit:main May 30, 2025
1231 of 1232 checks passed
@dhalbert dhalbert deleted the mpy-cross-static-build-fix branch May 30, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mpy-cross STATIC_BUILD not working
2 participants