Fix api inconsistency about temperature units #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As to husky-dev/firebase-iot-codelab#3 there is a strange design when temperature is read in Celsius by default and heatIndex is computed in Farenheit by default. This commit sets the default unit to Celsius for calculating heatIndex.
S == Scale does not clearly represents the flag purpose. Rename it to isFarenheit so it describes the flag purpose more precise
|
This PR is now quite old, so I don't really expect it to be merged, but I agree with its spirit and came here to fix the same issue. It would be nice to have unit consistency, with Celsius as defalt everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we read temperature the default units are Celsius and to get Fahrenheit we need to pass an additional flag. On the other hand heat index is calculated in Fahrenheit by default and there is a need to pass an additional boolean flag to retrieve a value in Celsius. See husky-dev/firebase-iot-codelab#3.
Description
This PR fixes the inconsistency by setting the default units to Celsius. Alongside this a little naming improvement has been done to make the purpose of flags in
readTemperaturemore clear.Limitations
Introduced changes are API-breaking, so a major version should be incremented in the release which will contain this patch.