Add support for AMS AS5600 12-bit on-axis magnetic rotary position sensor #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Jan 25, 2025
| @@ -448,3 +448,6 @@ | |||
| [submodule "libraries/drivers/pca9955b"] | |||
| path = libraries/drivers/pca9955b | |||
| url = https://github.com/noelanderson/CircuitPython_PCA9955B.git | |||
| [submodule "libraries/SUBFOLDER/as5600"] | |||
| path = libraries/SUBFOLDER/as5600 | |||
There was a problem hiding this comment.
SUBFOLDER here needs to be changed to either drivers or helpers. In this case I think drivers is most appropriate.
There was a problem hiding this comment.
lol, well that's embarrassing. I'll fix and start a new PR
FoamyGuy
requested changes
Jan 25, 2025
There was a problem hiding this comment.
I think you've accidentally created a directory named SUBFOLDER by copying the command from the guide perhaps.
"SUBFOLDER" should be replaced with either drivers or helpers, not used literally.
It might be easiest to start with a fresh branch and make a new PR. Otherwise you'll need to remove the new submodule and add it back under the drivers folder which is most appropriate for this addition I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a driver library that adds support for the AMS AS5600 12-bit on-axis magnetic rotary position sensor.
https://ams-osram.com/products/sensor-solutions/position-sensors/ams-as5600-position-sensor