Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titano #538

Closed
wants to merge 2 commits into from
Closed

Add titano #538

wants to merge 2 commits into from

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Jan 16, 2024

Drafting this to check build before review

@tyeth tyeth force-pushed the add-titano branch 5 times, most recently from 16a9d72 to c704a0e Compare January 17, 2024 15:08
@tyeth tyeth marked this pull request as ready for review January 17, 2024 15:09
@tyeth tyeth requested a review from brentru January 17, 2024 15:09
@tyeth
Copy link
Contributor Author

tyeth commented Jan 17, 2024

As I've reverted the branch of ci-arduino change, I thought there needs to be a merge of adafruit/ci-arduino#177 however the build has completed regardless.

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question/comment

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, LGTM

@tyeth
Copy link
Contributor Author

tyeth commented Jan 17, 2024

May not be ready for prime time, or at least I can't get my titano to boot correctly (red light of doom)

@tyeth
Copy link
Contributor Author

tyeth commented Jan 29, 2024

This will be included/superseded by #540

@tyeth tyeth closed this Jan 29, 2024
@tyeth tyeth deleted the add-titano branch March 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants