Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 64x32 displays #196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jgromes
Copy link

@jgromes jgromes commented Jan 3, 2021

Based on changes in #71, tested with a 64x32 I2C OLED module connected to STM322F1 and works fine.

@jgromes
Copy link
Author

jgromes commented Jan 3, 2021

Not sure what exactly is clang complaining about, probably something in the formatting.

@BillyDonahue
Copy link
Contributor

Not sure what exactly is clang complaining about, probably something in the formatting.

The clang check is really a clang-format check.

In the output of the check was a patch you can apply to your PR to fix it up.

https://github.com/adafruit/Adafruit_SSD1306/pull/196/checks?check_run_id=1639652316

@jgromes
Copy link
Author

jgromes commented Jan 4, 2021

@BillyDonahue thanks, all fixed now.

@jgromes
Copy link
Author

jgromes commented Jan 10, 2021

Hey guys, could we merge this? I've been using a 64x32 display for a while now and everything is working flawlessly.

@ladyada
Copy link
Member

ladyada commented Jan 10, 2021

hi we're going thru a big refactor of this library and we'll include this as part of it!

@KenjutsuGH
Copy link

I hope this support will still make it to the library... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants