fix compatibility with differing /sys/bus/gpio/devices/gpiochip*
#967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a USB to Serial cable I note that initialising the blinka library would crash. I'd receive an error saying that it cannot open the file
/sys/bus/gpio/devices/gpiochip14/of_node/compatible. This was because the FTDI cable had added an additional gpioChip which didn't have the expected path structure.I feel like it's safe to add an
is_file()check to this path before opening and this does make the issue go away on my setup.Please let me know if there are:
Additionally, is it worth looking if we do this sort of blind read elsewhere and fix those too? Could then add a generic function.