Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modified command #21

Merged
merged 8 commits into from
Jun 14, 2020
Merged

Add modified command #21

merged 8 commits into from
Jun 14, 2020

Conversation

dotKuro
Copy link
Contributor

@dotKuro dotKuro commented Jun 13, 2020

This adds the modified command as suggested in #18.

Currently it shows all tasks that were modified sorted by the modified_utc. I'm not sure if only showing open tasks would be better. Also when showing these tasks I think we should add a column showing the modified_utc.

What do you think? I will mark this PR as draft until these points are discussed.

@ad-si
Copy link
Owner

ad-si commented Jun 13, 2020

  • I think it's fine to show open and closed tasks. The idea is to have a command to see what you recently worked on, even if it was closing a task.
  • A column with the modified UTC would certainly be cool, but this will need some bigger changes. Ideally the table printing code would be modularized to allow any fields to be printed as a table.

Btw: Can you maybe rewrite the code to not use where? I absolutely loathe it and don't want to have it the code. 😅

@dotKuro
Copy link
Contributor Author

dotKuro commented Jun 13, 2020

  • Should I use let foo in instead?

  • If you have any input on how to modularize the table printing well I can try to implement that.

@ad-si
Copy link
Owner

ad-si commented Jun 13, 2020

Should I use let foo in instead?

yes! 👍

If you have any input on how to modularize the table printing well I can try to implement that.

Maybe something in the sprit of this?

buildTable :: [{fieldName :: Text, maxWidth :: Int, color :: Color}] -> [Task] -> Doc

But this could get pretty involved. So not sure if you want to bother with this 😅

@dotKuro dotKuro marked this pull request as ready for review June 14, 2020 10:05
@ad-si ad-si merged commit 7548d43 into ad-si:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants