-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default value to get command #20
Conversation
Just ignore the last two commits. The first one should be pushed to another branch and the second one just reverts the first one. 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That won't work. Filter expressions are and
ed, so it's not possible to overwrite it the way you implemented it. tl get state:open AND state:done
makes not sense.
It must be implemented somewhere in the runFilter
function or similar
No The parser looks for at least one string argument other whise it will fail. The <|> provides an alternaitve in case the parser fails. Which means it will either use any arguemnt provided (i.e Is that what was meant with the todo? I might got it wrong. |
Ah ok, sorry, didn't properly read the code. But this means that
|
This is exactly the behaviour upstream has currently. I propably missunderstood the todo.
What was this suppose to mean? If you not specify |
If a filter without a |
02e11d1
to
3368692
Compare
Added in 826aa99. |
I set the default for the get command to "state:open" as stated in #18