Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct intersections for named area (explicitly check them against t… #41

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

patrickbr
Copy link
Member

…he R-Tree), this addresses point 1 from issue #14

…he R-Tree), this addresses point 1 from issue #14
Copy link
Member

@lehmann-4178656ch lehmann-4178656ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a quick question: does this change anything in the expected output - or better: can this change be represented via a test to ensure I don't break it in the future?

@patrickbr
Copy link
Member Author

patrickbr commented Dec 23, 2022

Yes, before this commit, an "intersects" was only written for named areas where one contained the other, so the output changed quite a bit (many more intersects relations). It should be easy to add a test for this, I will look into this :)

BTW, we still don't have way/way intersects, but this would require having random access to the ways stored on disk (to retrieve the exact geometry for intersect candidates). I am not sure whether the current boost::serialization approach can handle random accesses (maybe it can).

@patrickbr
Copy link
Member Author

patrickbr commented Jan 9, 2023

@lehmann-4178656ch, the named area intersections are now tested. I also made the intersect relations symmetric, that is, if a intersects_area b is added, b intersects_area a is also added (the same for intersects_nonarea).

@patrickbr patrickbr merged commit db33605 into master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants