Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Typescript Migration] browser-preload.browser.js --> browser-preload.browser.ts #2591

Conversation

IzStriker
Copy link
Contributor

TypeScript migration #1483
Precondition for another PR which is in progress (#2584)

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit cd6bf9b
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66196130f57d710008badfbe
😎 Deploy Preview https://deploy-preview-2591.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added the 🚧 WIP label Apr 12, 2024
Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.62 MB → 4.62 MB (+222 B) +0.00%
Changeset
File Δ Size
src/browser-preload.browser.ts 🆕 +3.6 kB 0 B → 3.6 kB
src/browser-preload.browser.js 🔥 -3.38 kB (-100%) 3.38 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.56 MB → 2.56 MB (+222 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 202.51 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/real-module.js 22.09 kB 0%
static/js/wide.js 371.33 kB 0%
static/js/import.js 118.98 kB 0%
static/js/ReportRouter.js 1.18 MB 0%

Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@IzStriker
Copy link
Contributor Author

I'm being dumb!

@IzStriker IzStriker closed this Apr 13, 2024
@IzStriker IzStriker deleted the typescript-migration-browser-preload branch April 13, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant