Enable -Wconversion
#746
Merged
Enable -Wconversion
#746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
False positives from Sonarcloud. |
stephenswat
force-pushed
the
build/enable_Wconversion
branch
8 times, most recently
from
095b81c
to
716ce87
Compare
|
Finally passed the tests. @krasznaa |
stephenswat
force-pushed
the
build/enable_Wconversion
branch
from
716ce87
to
60af5af
Compare
beomki-yeo
reviewed
Oct 23, 2024
beomki-yeo
reviewed
Oct 23, 2024
stephenswat
force-pushed
the
build/enable_Wconversion
branch
from
60af5af
to
4d85767
Compare
|
This commit replaces the existing `Wfloat-conversion` flag with the more strict `-Wconversion` and fixes related errors. These were mostly harmless integer conversions, but certainly also some nasty improper floating point-to-integer conversions which may constitute bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the existing
Wfloat-conversionflag with the more strict-Wconversionand fixes related errors. These were mostly harmless integer conversions, but certainly also some nasty improper floating point-to-integer conversions which may constitute bugs.