Add wait or ignore for all async copies
#645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using acts-project/vecmem#286 I was able to find a few more cases where we do not properly wait for or ignore events. In this PR I opted to add those missing statements according to a simple heuristic, i.e. I added waits for all SYCL and share code and I added ignores for all CUDA code. Reason for this is that CUDA events are stream-ordered, so you can't really shoot yourself in the foot too much. SYCL events, on the other hand, are unordered, so they need stricted checking.
stephenswat
added
bug
|
@krasznaa Just so you're also aware of this. Will rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using acts-project/vecmem#286 I was able to find a few more cases where we do not properly wait for or ignore events. In this PR I opted to add those missing statements according to a simple heuristic, i.e. I added waits for all SYCL and share code and I added ignores for all CUDA code. Reason for this is that CUDA events are stream-ordered, so you can't really shoot yourself in the foot too much. SYCL events, on the other hand, are unordered, so they need stricted checking.