feat: implement digitization configurator for detray geometries #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
feat-digi-configurator
branch
6 times, most recently
from
1aae1b9
to
f67290c
Compare
niermann999
force-pushed
the
feat-digi-configurator
branch
3 times, most recently
from
6ac75bf
to
a515f4b
Compare
|
I have prepared a meta-config file for a toy detector with 3 and 7 endcaps and generated the corresponding digitization config files. The unittest in this PR expects to find the geometry and digi config files for the toy detector in the data directory |
niermann999
requested review from
beomki-yeo and
krasznaa
and removed request for
beomki-yeo
niermann999
force-pushed
the
feat-digi-configurator
branch
from
a515f4b
to
0449dba
Compare
krasznaa
approved these changes
Oct 18, 2023
krasznaa
force-pushed
the
feat-digi-configurator
branch
from
0449dba
to
a7cb00a
Compare
niermann999
force-pushed
the
feat-digi-configurator
branch
2 times, most recently
from
30e06fa
to
9567764
Compare
…nfiguration and generate a full digitization configuration for a detray geometry. This is mostly useful for geometries that are generated in detray, as this should hopefully become compatible with ACTS generated tracking geometries at some point, in which case the detray surfaces will provide a source link to the corresponding ACTS surface. The configuration can only be done per volume and extra bit. Since the current ACTS version in traccc does not support extra-bit matching in the GeometryHierarchyMap yet, and because detray has no facilities to set extra bits during geometry IO yet, this part of the configuration has not been tested so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a digitization configurator that can read a digitization meta configuration and generate a full digitization configuration for a detray geometry. This is mostly useful for geometries that are generated in detray, as this should hopefully become compatible with ACTS generated tracking geometries at some point, in which case the detray surfaces will provide a source link to the corresponding ACTS surface.
The configuration can only be done per volume and extra bit. Since the current ACTS version in traccc does not support extra-bit matching in the GeometryHierarchyMap yet, and because detray has no facilities to set extra bits during geometry IO yet, this part of the configuration has not been tested so far.