Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to calculate pvalue #405

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

beomki-yeo
Copy link
Contributor

Depends on #403.

This PR adds functions required for pvalue calculation.
I am thinking of using the pvalue for the Kalman filternig improvement without introducing ROOT library into traccc core

@beomki-yeo beomki-yeo marked this pull request as draft May 18, 2023 16:16
@stephenswat
Copy link
Member

stephenswat commented May 18, 2023

Is there a reason to use a custom Γ function rather than std::tgamma? Unless physicists have a different Γ function that I am not familiar with.

Edit: Or if you're going to be using it in device code.

@stephenswat stephenswat added the feature New feature or request label May 18, 2023
@beomki-yeo
Copy link
Contributor Author

beomki-yeo commented May 18, 2023

It is the same gamma and I didn't know that std::tgamma exists.
Thing is that I am not sure if the lower and upper integral can be obtained from std functions. I will be super happy to use them if that is supported

And yes, I am thinking of using it in the device code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants