-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nav): Gen3 Navigation policies and factory #3760
base: main
Are you sure you want to change the base?
feat(nav): Gen3 Navigation policies and factory #3760
Conversation
Their lifetime needs to be controlled
@asalzburger I'm making some changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general comments and questions about the logic from my side
After discussion with @andiwand, I refactored the interface of the function contained in the I'm also wrapping the navigation stream into a separate wrapper object called This is to be complemented (in a future PR) with a method like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes a lot of sense!
Lets get this in!
Terminology:
NavigationPolicyFactory
. Its job is to make defining a factory that produces a "MultiNavigationPolicy" easy, like:Part of #3502