-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validate track parameters #3756
base: main
Are you sure you want to change the base?
Conversation
0a02484 contains your feedback @paulgessinger |
This fires basically everywhere. It would take quite some time to fix every single problem. I think we can just add the functionality and not assert on it for now. The question is if we really want to assert on it. $\phi $ being out of range usually does not hurt. With |
Quality Gate passedIssues Measures |
This is a bit frustrating: we have a bunch of invalid track parameters in the code which are generated randomly in different ways. I think it would be good to have one mechanism of generating random track parameters which has to be parameterized before we can continue with this PR. |
Adds two free functions which allow checking
BoundVector
s andFreeVectors
s for valid track parameters. This is then used asassert
s in the track parameter EDM.blocked by