Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: reword sentence #3530

Merged
merged 3 commits into from
Dec 29, 2024
Merged

docs: reword sentence #3530

merged 3 commits into from
Dec 29, 2024

Conversation

c-git
Copy link
Contributor

@c-git c-git commented Dec 13, 2024 •
edited by robjtede
Loading

PR Type

DOCS Update

PR Checklist

  • Tests for the changes have been added / updated. (NA)
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages. (NA)
  • Format code with the latest stable rustfmt. (Done in the browser, will have to come back to do this).
  • (Team) Label with affected crates and semver status. (Uncertain how to do this)

Overview

Rewords a sentence from the docs that was a bit confusing. Modified to flow more naturally.

@c-git
docs: reword sentence
a3e019a 
The sentence was a bit hard to follow. I think it seems more natural now.
robjtede
robjtede approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@robjtede robjtede added A-web project: actix-web B-semver-norelease change that does not require a release labels Dec 13, 2024
@c-git
Copy link
Contributor Author

c-git commented Dec 13, 2024

Sorry was going to come back and fix the rust fmt issue. Had done it in the browser so couldn't run rustfmt on it.

@robjtede robjtede enabled auto-merge December 29, 2024 14:30
@robjtede robjtede added this pull request to the merge queue Dec 29, 2024
Merged via the queue into actix:master with commit 8200e4e Dec 29, 2024
13 checks passed
@c-git c-git deleted the patch-1 branch December 29, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-web project: actix-web B-semver-norelease change that does not require a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-git @robjtede