Skip to content

Update gemspec to work with AA 1.2.1 and 1.1.0 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2018
Merged

Update gemspec to work with AA 1.2.1 and 1.1.0 #41

merged 1 commit into from
Mar 29, 2018

Conversation

workgena
Copy link
Contributor

@workgena workgena commented Mar 29, 2018 •
edited
Loading

Add ActiveAdmin verions to the Travis-matrix:

  • 1.1.0
  • 1.2.1

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 96.045% when pulling 3cc8e9e on workgena:JNajera-master into 672ef45 on activeadmin-plugins:master.

@coveralls
Copy link

coveralls commented Mar 29, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 95.238% when pulling 76bde92 on workgena:JNajera-master into 672ef45 on activeadmin-plugins:master.

@JNajera @workgena
Update gemspec to work with AA 1.2.1 and bump 6.0.2
76bde92 
Use "soft" dependency with ActiveAdmin version

Add ActiveAdmin versions to the Travis-matrix:
- 1.1.1
- 1.2.1
@workgena workgena force-pushed the JNajera-master branch 3 times, most recently from 6a956c6 to 76bde92 Compare March 29, 2018 17:12
@workgena workgena changed the title WIP: update Travis-matrix to use activeadmin vesions Update gemspec to work with AA 1.2.1 and 1.1.0 Mar 29, 2018
@workgena workgena mentioned this pull request Mar 29, 2018
Closed
@workgena workgena merged commit 0f54acf into activeadmin-plugins:master Mar 29, 2018
@workgena
Copy link
Contributor Author

workgena commented Mar 29, 2018 •
edited
Loading

This is "collaboration" Pull Request with @JNajera originally PR #40
I've added Travis-matrix to test with AA 1.1.0/1.2.1 and Rails 4/5

@yaaase
Copy link

yaaase commented Mar 29, 2018

Thanks so much for doing this! We really appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@workgena @coveralls @yaaase @JNajera