Add exists? to Relation#349
Open
michebble wants to merge 1 commit into
Open
Conversation
ActiveRecord allows calling exists? on Realtions, however ActiveHash currently only allows calling it on the base model. Adding the method to Realtion provides functionality that those familar with ActiveRecord expect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActiveRecord allows calling
exists?on a relation, however ActiveHash currently only allows calling it on the base model. Adding the method to Relation provides functionality that those familiar with ActiveRecord expect.I needed to monkey patch my app to get this behaviour and would appropriate it if you would consider including this in the next release. I would like to get rid of the monkey patch if possible