Skip to content

Fix actual_root_path implementation #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drewbug wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix actual_root_path implementation #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_file/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def extension
protected :extension

def actual_root_path
root_path || Dir.pwd
root_path || File.dirname(File.realpath(__FILE__))

@kbrock kbrock Feb 11, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work? File.new(File.dirname(__FILE__)).realpath

I'm assuming we want to use File.dirname(__FILE__) over __dir__ for ruby version compatibility. too bad.

@kbrock kbrock Aug 4, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, in rails > 2.0, this is __dir__

Anyone have an opinion if this change is still necessary?

end
protected :actual_root_path

Expand Down