Improve release script #917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When using the [action versioning recommendations](https://github.com/actions/toolkit/blob/master/docs/action-versioning.md#recommendations), a commit can have duplicate tags (v2, v2.1.2). - The previous implementation did not take that into consideration. - With this new implementation, v2.1.2 is returned even when v2 is the newer commit tag (which is usually the case). - Also, when running this script from another branch (let's say 'releases/v1'), the previous implementation would return newer tags in other branches. - NOTE: This new implementation only searches for annotated tags.
- Previously, when the git push command failed, the script would still echo a success message. - This commit also makes sure the git describe command does not terminate the script.
- Using `--follow-tags` instead of `--tags` can be the saner option - `follow-tags` also pushes commits
This implementation also creates a `releases/v#` branch off of the previous major version tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the release script to be slightly more robust, and updates related documentation.
The new implementation:
releases/v#branch for the previous major version, when creating a major release