-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/gem-push.yml setup-ruby fix #2443
Open
MayCXC
wants to merge
13
commits into
actions:main
Choose a base branch
from
MayCXC:MayCXC-setup-ruby-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
08a53f7
remov PR trigger and .x from ruby-version
MayCXC 1eefebe
Update gem-push.yml
MayCXC b9ca79d
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC 6e74022
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC 07cb14d
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC 89724c3
Update gem-push.yml
MayCXC 7fdf8cd
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC 69edfb9
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC d31993f
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC 0380eff
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC 302fd32
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC a74391b
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC 7519542
Merge branch 'main' into MayCXC-setup-ruby-fix
MayCXC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,11 @@ | ||
name: Ruby Gem | ||
|
||
on: | ||
push: | ||
branches: [ $default-branch ] | ||
pull_request: | ||
branches: [ $default-branch ] | ||
release: | ||
types: [created] | ||
|
||
jobs: | ||
build: | ||
build-and-publish: | ||
name: Build + Publish | ||
runs-on: ubuntu-latest | ||
permissions: | ||
|
@@ -22,7 +20,7 @@ jobs: | |
# uses: ruby/setup-ruby@v1 | ||
uses: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf # v1.146.0 | ||
with: | ||
ruby-version: 2.6.x | ||
ruby-version: "2.6" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in my tests |
||
|
||
- name: Publish to GPR | ||
run: | | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this because it is very unusual to publish unapproved contributions as a package from a CI workflow. This leads to cases where e.g a gem gets published to rubygems before its code is reviewed, and then even if it is approved, an error is raised when it gets published again with the same version on merge. An alternative would be to disable just the "Publish to RubyGems" step on PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, it may be better to use a release trigger like in npm-publish.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… or in pypa/python publihsing. Yes, this should be updated to trigger on GH Release publish:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, it uses a release trigger now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1