Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonarqube.yml after latest release of the action #2404

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

henryju
Copy link

@henryju henryju commented May 23, 2024

We have released a new version of the action, and consequently I am updating the template.

@henryju henryju requested review from a team as code owners May 23, 2024 12:47
@github-actions github-actions bot added the code-scanning Related to workflows that show on the Code Scanning setup page label May 23, 2024
Copy link
Contributor

@thyeggman thyeggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryju I'm going through our backlog of PRs and see that your Action has a newer version aecaf43ae57e412bd97d70ef9ce6076e672fe0a9 (2.3.0), if you go ahead and update the version (and any other necessary changes) I will merge this PR

# uses: SonarSource/sonarqube-scan-action@v1.1.0
uses: SonarSource/sonarqube-scan-action@7295e71c9583053f5bf40e9d4068a0c974603ec8
# uses: SonarSource/sonarqube-scan-action@v2.1.0
uses: SonarSource/sonarqube-scan-action@86fe81775628f1c6349c28baab87881a2170f495
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: SonarSource/sonarqube-scan-action@86fe81775628f1c6349c28baab87881a2170f495
uses: SonarSource/sonarqube-scan-action@aecaf43ae57e412bd97d70ef9ce6076e672fe0a9

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed your message during my vacations. We now have another release, so I have updated the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-scanning Related to workflows that show on the Code Scanning setup page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants