Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Semgrep to new container version #2140

Closed
wants to merge 5 commits into from

Conversation

GeekMasher
Copy link

@GeekMasher GeekMasher commented Aug 16, 2023

Pre-requisites

  • Prior to submitting a new workflow, please apply to join the GitHub Technology Partner Program: partner.github.com/apply.

Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.


Tasks

For all workflows, the workflow:

  • Should be contained in a .yml file with the language or platform as its filename, in lower, kebab-cased format (for example, docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
  • Should use sentence case for the names of workflows and steps (for example, "Run tests").
  • Should be named only by the name of the language or platform (for example, "Go", not "Go CI" or "Go Build").
  • Should include comments in the workflow for any parts that are not obvious or could use clarification.
  • Should specify least privileged permissions for GITHUB_TOKEN so that the workflow runs successfully.

For CI workflows, the workflow:

  • Should be preserved under the ci directory.
  • Should include a matching ci/properties/*.properties.json file (for example, ci/properties/docker-publish.properties.json).
  • Should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].
  • Packaging workflows should run on release with types: [ created ].
  • Publishing workflows should have a filename that is the name of the language or platform, in lower case, followed by "-publish" (for example, docker-publish.yml).

For Code Scanning workflows, the workflow:

  • Should be preserved under the code-scanning directory.
  • Should include a matching code-scanning/properties/*.properties.json file (for example, code-scanning/properties/codeql.properties.json), with properties set as follows:
    • name: Name of the Code Scanning integration.
    • creator: Name of the organization/user producing the Code Scanning integration.
    • description: Short description of the Code Scanning integration.
    • categories: Array of languages supported by the Code Scanning integration.
    • iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in the icons directory.
  • Should run on push to branches: [ $default-branch, $protected-branches ] and pull_request to branches: [ $default-branch ]. We also recommend a schedule trigger of cron: $cron-weekly (for example, codeql.yml).

Some general notes:

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or
  • This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. We require that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies.
  • Automation and CI workflows cannot be dependent on a paid service or product.

@GeekMasher GeekMasher requested review from a team as code owners August 16, 2023 11:36
@github-actions github-actions bot added the code-scanning Related to workflows that show on the Code Scanning setup page label Aug 16, 2023
@GeekMasher GeekMasher changed the title Update Semgrep to support container version Update Semgrep to new container version Aug 16, 2023
@GeekMasher GeekMasher requested a review from a team as a code owner February 21, 2024 13:09
@GeekMasher GeekMasher requested a review from a team as a code owner May 2, 2024 08:00
Copy link
Contributor

@alexisabril alexisabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @GeekMasher! I noticed the following from the Semgrep documentation. Would you confirm if that's intended for this workflow? Specifically the conflict between rules and the app token defined in the same workflow.

Comment on lines +59 to +61
# Add the rules that Semgrep uses by setting the SEMGREP_RULES environment variable.
# more at semgrep.dev/explore
SEMGREP_RULES: p/default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add the rules that Semgrep uses by setting the SEMGREP_RULES environment variable.
# more at semgrep.dev/explore
SEMGREP_RULES: p/default

Noting that SEMGREP_RULES should not be set in the same job as SEMGREP_APP_TOKEN, per the latest docs: https://semgrep.dev/docs/semgrep-ci/ci-environment-variables/#semgrep_app_token

Screenshot 2024-03-25 at 3 42 55 PM

Copy link

github-actions bot commented Aug 1, 2024

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

schedule:
- cron: $cron-weekly
# Scan on-demand through GitHub Actions interface:
workflow_dispatch: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
workflow_dispatch: {}
workflow_dispatch:

@GeekMasher GeekMasher closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-scanning Related to workflows that show on the Code Scanning setup page no-pr-activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants