Skip to content

Implement DecreaseProcessPriority on Windows OS #4437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rich7690 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement DecreaseProcessPriority on Windows OS #4437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions src/Runner.Sdk/ProcessInvoker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ namespace GitHub.Runner.Sdk
{

// The implementation of the process invoker does not hook up DataReceivedEvent and ErrorReceivedEvent of Process,
// instead, we read both STDOUT and STDERR stream manually on separate thread.
// The reason is we find a huge perf issue about process STDOUT/STDERR with those events.
// instead, we read both STDOUT and STDERR stream manually on separate thread.
// The reason is we find a huge perf issue about process STDOUT/STDERR with those events.
public sealed class ProcessInvoker : IDisposable
{
private Process _proc;
Expand Down Expand Up @@ -233,7 +233,7 @@ public async Task<int> ExecuteAsync(
_proc.StartInfo.RedirectStandardError = true;
_proc.StartInfo.RedirectStandardOutput = true;

// Ensure we process STDERR even the process exit event happen before we start read STDERR stream.
// Ensure we process STDERR even the process exit event happen before we start read STDERR stream.
if (_proc.StartInfo.RedirectStandardError)
{
Interlocked.Increment(ref _asyncStreamReaderCount);
Expand Down Expand Up @@ -568,7 +568,31 @@ private void KillProcessTree()

private void DecreaseProcessPriority(Process process)
{
#if OS_LINUX
#if OS_WINDOWS
var enableWindowsPriority = Environment.GetEnvironmentVariable("PIPELINE_JOB_DECREASE_PROCESS_PRIORITY") ?? "";
if (string.Equals(enableWindowsPriority, "true", StringComparison.OrdinalIgnoreCase))
{
try
{
var currentPriority = Process.GetCurrentProcess().PriorityClass;
var newPriority = currentPriority switch
{
ProcessPriorityClass.RealTime => ProcessPriorityClass.High,
ProcessPriorityClass.High => ProcessPriorityClass.AboveNormal,
ProcessPriorityClass.AboveNormal => ProcessPriorityClass.Normal,
ProcessPriorityClass.Normal => ProcessPriorityClass.BelowNormal,
_ => ProcessPriorityClass.Idle,
};
process.PriorityClass = newPriority;
Trace.Info($"Set process priority to {newPriority} (current process: {currentPriority}) for PID: {process.Id}.");
}
catch (Exception ex)
{
Trace.Info($"Failed to set process priority for PID: {process.Id}.");
Trace.Info(ex.ToString());
}
}
#elif OS_LINUX
int oomScoreAdj = 500;
string userOomScoreAdj;
if (process.StartInfo.Environment.TryGetValue("PIPELINE_JOB_OOMSCOREADJ", out userOomScoreAdj))
Expand Down Expand Up @@ -659,7 +683,7 @@ private bool ConsoleCtrlHandler(ConsoleCtrlEvent ctrlType)
return true;
}

// If the function handles the control signal, it should return TRUE.
// If the function handles the control signal, it should return TRUE.
// If it returns FALSE, the next handler function in the list of handlers for this process is used.
return false;
}
Expand Down