Fix helm chart validation workflow#4479
Open
nikola-jokic wants to merge 1 commit intomasterfrom
Open
Conversation
nikola-jokic
requested review from
a team,
Steve-Glass,
mumoshu,
rentziass and
toast-gear
as code owners
Contributor
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GHA Helm chart validation pipeline to lint/test the intended set of charts (including experimental ones) and adjusts the testing approach used in CI.
Changes:
- Add experimental charts to the chart-testing (
ct) config so they’re included in linting. - Populate the
validate-chartjob with checkout/helm/python/ct steps and runct lint. - Remove Go-based template tests for experimental charts and run helm-unittest for experimental charts in CI.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| charts/gha-runner-scale-set-experimental/tests/template_test.go | Removes Go-based template test for experimental scale-set chart. |
| charts/gha-runner-scale-set-controller-experimental/tests/template_test.go | Removes Go-based template test for experimental controller chart. |
| charts/.ci/ct-config-gha.yaml | Expands ct chart list to include experimental charts. |
| .github/workflows/gha-validate-chart.yaml | Reworks validation workflow: adds dedicated lint job steps and runs helm-unittest for experimental charts; removes some prior CI steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+56
to
+60
| - name: Run chart-testing (list-changed) | ||
| id: list-changed | ||
| run: | | ||
| ct version | ||
| changed=$(ct list-changed --config charts/.ci/ct-config-gha.yaml) |
| contains(steps.list-changed.outputs.changed_charts, 'charts/gha-runner-scale-set-controller-experimental') || | ||
| contains(steps.list-changed.outputs.changed_charts, 'charts/gha-runner-scale-set-experimental') | ||
| run: | | ||
| helm plugin install https://github.com/helm-unittest/helm-unittest.git |
Comment on lines
110
to
114
| - name: Run helm-unittest (gha-runner-scale-set-controller-experimental) | ||
| if: contains(steps.list-changed.outputs.changed_charts, 'charts/gha-runner-scale-set-controller-experimental') | ||
| run: | | ||
| helm unittest ./charts/gha-runner-scale-set-controller-experimental/ | ||
|
|
||
| - name: Run helm-unittest (gha-runner-scale-set-experimental) |
Comment on lines
110
to
113
| - name: Run helm-unittest (gha-runner-scale-set-controller-experimental) | ||
| if: contains(steps.list-changed.outputs.changed_charts, 'charts/gha-runner-scale-set-controller-experimental') | ||
| run: | | ||
| helm unittest ./charts/gha-runner-scale-set-controller-experimental/ | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.