Adds support for properly logging Arrays #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for providing this gem. I noticed a possible issue in my team's usage of it. Without this patch, an Array will be flattened, resulting in keys and values becoming mismatched.
Eg, given a request that responds to
some_array_method
with[1,2]
:You might expect to see log entries having tags like:
but it will actually have tags like:
This can be worked around by passing a proc which calls
to_s
on any array values,but it seems unlikely users would expect their keys to map to different values if some method returns an Array.