Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeviceDetect proxy to autoload. #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add DeviceDetect proxy to autoload. #36

wants to merge 1 commit into from

Conversation

koekaverna
Copy link

Add proxy class to autoloading to fix problem when already exists file with the same hash overrwited on every request

@koekaverna koekaverna mentioned this pull request Nov 28, 2023
Open
@renanbr renanbr requested a review from renedelima November 29, 2023 20:16
renanbr
renanbr previously approved these changes Nov 29, 2023
View reviewed changes
@renanbr
Copy link
Member

renanbr commented Dec 10, 2023

Thanks for this PR @koekaverna

The DoctrineMongoDBBundle registers (and unregisters) its autoloader in the Kernel.

This seems a better approach.

We could make createConfiguration() public and play with this in the Kernel if the service is available, or skip this completely if the service isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanbr renanbr renanbr left review comments

@renedelima renedelima Awaiting requested review from renedelima

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koekaverna @renanbr