Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1423: PHPUnit 10 #1820

Merged
merged 4 commits into from
Oct 23, 2024
Merged

CLI-1423: PHPUnit 10 #1820

merged 4 commits into from
Oct 23, 2024

Conversation

danepowell
Copy link
Contributor

Motivation

Fixes CLI-1423

Proposed changes

Paratest dropped support for PHP 8.1 so we can't upgrade past 7.3.1. Unfortunately 7.3.1 is incompatible with newer versions of PHPUnit so we have to pin it until PHP 8.1 is EOL 😢

paratestphp/paratest#890

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (b67b4c8) to head (cc66c5f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1820      +/-   ##
============================================
- Coverage     92.76%   92.55%   -0.22%     
- Complexity     1822     1830       +8     
============================================
  Files           122      123       +1     
  Lines          6913     6929      +16     
============================================
  Hits           6413     6413              
- Misses          500      516      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit befc2dc into acquia:main Oct 23, 2024
11 of 12 checks passed
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1820/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1820/acli.phar
chmod +x acli.phar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant