Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1413: Set PHP compatibility level #1807

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Oct 4, 2024

Motivation

Fixes CLI-1413

Proposed changes

Set compatibility level according to acquia/coding-standards-php#37

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (cef7a69) to head (57b3086).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1807   +/-   ##
=========================================
  Coverage     92.78%   92.78%           
  Complexity     1818     1818           
=========================================
  Files           122      122           
  Lines          6817     6817           
=========================================
  Hits           6325     6325           
  Misses          492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 4, 2024

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1807/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1807/acli.phar
chmod +x acli.phar

@danepowell danepowell marked this pull request as ready for review October 4, 2024 16:59
@danepowell danepowell merged commit 5e491cf into acquia:main Oct 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant