Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make acli app:new:from:drupal7 default to the latest AMA recommendations on d.o #1588

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Make acli app:new:from:drupal7 default to the latest AMA recommendations on d.o #1588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e631e0
PHP defaults to no user agent. (Drupal.org's) GitLab requires it. So:…
wimleers Sep 1, 2023
0307191
Default to using the latest AMA recommendations instead of the hardco…
wimleers Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Command/App/NewFromDrupal7Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
fclose($config_resource);

// Parse recommendations for project builder.
$recommendations_location = __DIR__ . '/../../../config/from_d7_recommendations.json';
$recommendations_location = "https://git.drupalcode.org/project/acquia_migrate/-/raw/recommendations/recommendations.json";
if ($input->getOption('recommendations') !== NULL) {
$raw_recommendations_location = $input->getOption('recommendations');
try {
Expand All @@ -148,6 +148,9 @@
return Command::FAILURE;
}
}
// PHP defaults to no user agent. (Drupal.org's) GitLab requires it.
// @see https://www.php.net/manual/en/filesystem.configuration.php#ini.user-agent
ini_set('user_agent', 'ACLI');

Check warning on line 153 in src/Command/App/NewFromDrupal7Command.php

View workflow job for this annotation

GitHub Actions / Mutation Testing 

Escaped Mutant for Mutator "FunctionCallRemoval":

--- Original
+++ New
@@ @@
                 return Command::FAILURE;
             }
         }
-        // PHP defaults to no user agent. (Drupal.org's) GitLab requires it.
-        // @see https://www.php.net/manual/en/filesystem.configuration.php#ini.user-agent
-        ini_set('user_agent', 'ACLI');
+        
         $recommendations_resource = fopen($recommendations_location, 'r');
         $recommendations = Recommendations::createFromResource($recommendations_resource);
         fclose($recommendations_resource);
$recommendations_resource = fopen($recommendations_location, 'r');
$recommendations = Recommendations::createFromResource($recommendations_resource);
fclose($recommendations_resource);
Expand Down
Loading