Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for hosttech.ch/hosttech.eu #6209

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

baerengraben
Copy link

Adding Support for hosttech.ch/hosttech.eu

New try to pass workflow.

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@baerengraben
Copy link
Author

I have updated the outdated https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test. It now describes how to add security variables to github in 2025.

Now Docker test fails. This is despite the DNS entries being correctly added to hosttech (https://github.com/baerengraben/acme.sh/actions/runs/12955768870/job/36247925398#step:5:3911) and removed again successfully (https://github.com/baerengraben/acme.sh/actions/runs/12955768870/job/36247925398#step:5:7071).

I suspect there is something wrong with the workflow here. Can a maintainer check this?

@Neilpang
Copy link
Member

Neilpang commented Feb 8, 2025

no, the test is good. you need to check your code.

@baerengraben
Copy link
Author

I fear it is not an issue with my code. I'm using my script already for months on an Opnsense Firewall with no issues at all.

This Workflow (Docker step, that fails) successfully creates the acme-challenge as TXT records on the Hosttech DNS server and also deletes them successfully. I can monitor this live on the DNS server.
Nevertheless, the workflow fails. It is possible that I am not applying the workflow correctly in some way. I also can't make sense of the workflow error message. From my perspective, the script (my code) works correctly, but somehow the workflow returns "Fail."

On https://github.com/baerengraben/acme.sh/actions/runs/13220004347/job/36904036748#step:5:99

Testing wildcard domain. 
TestingDomain='***'
/root/.acme.sh/acme.sh --server "letsencrypt_test"  --issue -d "***" -d "*.***" --dns *** --dnssleep "***"  [PASS]
/root/.acme.sh/acme.sh --deactivate -d "***" >/dev/null 2>&1 [PASS]
/root/.acme.sh/acme.sh --revoke -d *** [PASS]
[Sat Feb  8 23:14:50 UTC 2025] The domain '***' seems to already have an ECC cert, let's use it.
 [FAIL] 
Run Failed

Unfortunately, I don't fully understand in detail what the workflow is testing. It seems to be testing a wildcard domain, but I don't have a wildcard domain under the TESTINGDOMAIN variable at all.

Can you please help me figure out how to get this workflow to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants