Skip to content

Conversation

badcf00d
Copy link

@badcf00d badcf00d commented Dec 1, 2023

This function call seems to mistakenly use conf directly rather than cconf which protects against conf being null:

struct conf_fprintf cconf = conf ? *conf : conf_fprintf__defaults;

This makes pahole segfault seemingly whenever --show_reorg_steps is used

@Sinamore
Copy link

@acmel sorry to bother you, but this segfault is still an issue. Could you merge it or advise what needs to be done, if merge is not possible?

@alan-maguire
Copy link
Contributor

It looks like it will need to be merged with the latest "next" branch. Can you do that and send a patch to [email protected] ? We manage things through the mailing list rather than github PRs as per the linux kernel dev process. Archives including examples can be found at https://lore.kernel.org/dwarves . Thank you!

@badcf00d
Copy link
Author

Hi there, yep can do

@badcf00d
Copy link
Author

Patch available here: https://lore.kernel.org/dwarves/[email protected]/T/#u

@alan-maguire
Copy link
Contributor

alan-maguire commented May 20, 2025

got it, thanks! one more thing - our process requires a Signed-off-by: Real Name <email address> ; could you resend a v2 with subject line "PATCH v2 dwarves: Fix pahole segfault with --show_reorg_steps option" with that included?

@alan-maguire
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants