Skip to content

BTF section error-handling and alignment #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

BTF section error-handling and alignment #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fdee39
btf: improve error-handling around objcopy
myxoid Dec 2, 2020
a3d940a
btf: set .BTF section alignment to 16
myxoid Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions libbtf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,18 +785,27 @@ static int btf_elf__write(const char *filename, struct btf *btf)
if (write(fd, raw_btf_data, raw_btf_size) != raw_btf_size) {
fprintf(stderr, "%s: write of %d bytes to '%s' failed: %d!\n",
__func__, raw_btf_size, tmp_fn, errno);
goto out;
goto unlink;
}

snprintf(cmd, sizeof(cmd), "%s --add-section .BTF=%s %s",
llvm_objcopy, tmp_fn, filename);
if (system(cmd)) {
fprintf(stderr, "%s: failed to add .BTF section to '%s': %d!\n",
__func__, tmp_fn, errno);
goto out;
__func__, filename, errno);
goto unlink;
}

snprintf(cmd, sizeof(cmd), "%s --set-section-alignment .BTF=16 %s",
llvm_objcopy, filename);
if (system(cmd)) {
/* non-fatal, this is a nice-to-have and it's only supported from LLVM 10 */
fprintf(stderr, "%s: warning: failed to align .BTF section in '%s': %d!\n",
__func__, filename, errno);
}

err = 0;
unlink:
unlink(tmp_fn);
}

Expand Down