-
Notifications
You must be signed in to change notification settings - Fork 6
Added insets and made dark mode default #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Before merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements safe area insets support for better mobile device compatibility and changes the default theme to dark mode. The changes include refactoring the personal info page to use a stacked navigation pattern, replacing the edge-to-edge Android plugin with a cross-platform safe area plugin, and reorganizing page components.
- Implements safe area insets using
capacitor-plugin-safe-areafor proper handling of notches and system UI - Makes dark mode the default theme (changed from light mode)
- Refactors personal info section to use stacked navigation pattern with separate component files
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/routes/pages/personalInfo/settings.svelte |
Updated navigation to use stacked nav controller and made dark mode toggle async |
src/routes/pages/personalInfo/personalInfo.svelte |
New component extracting personal info page logic with added content padding |
src/routes/pages/personalInfo/personSkeleton.svelte |
New skeleton loading component for personal info (contains typo in script tag) |
src/routes/pages/personalInfo/infoItem.svelte |
New component for displaying user information with clipboard functionality |
src/routes/pages/personalInfo/faq.svelte |
Added SubPageHeader for stacked navigation support |
src/routes/pages/personalInfo/about.svelte |
Enhanced with maintainer badges, contributor shuffling, and updated translations |
src/routes/pages/personalInfo/+page.svelte |
Simplified to wrapper component using StackedNav |
src/routes/login/+page.svelte |
Added safe area padding to language switcher |
src/routes/faq/+page.svelte |
Removed (moved to personalInfo section) |
src/routes/about/+page.svelte |
Removed (moved to personalInfo section) |
src/lib/translations/translations.js |
Updated about section translations with consolidated text and new maintainer labels |
src/lib/globalFunctions/nativeSettings.ts |
Replaced edge-to-edge plugin with safe area plugin implementation |
src/lib/globalFunctions/darkMode.ts |
Changed default mode to dark and updated status bar styling |
src/lib/components/shared/AristomateTabBar.svelte |
Applied safe area insets to tab bar positioning |
src/lib/components/recentResults/recents.svelte |
Added unused Card import |
src/lib/components/personalInfo/contributors.json |
Added maintainer flags to contributor entries |
package.json |
Replaced edge-to-edge plugin with safe area plugin |
android/variables.gradle |
Increased minSdkVersion from 26 to 30 |
android/capacitor.settings.gradle |
Updated plugin references |
android/app/capacitor.build.gradle |
Updated plugin dependencies |
Comments suppressed due to low confidence (10)
src/routes/pages/personalInfo/settings.svelte:186
- The
aria-hiddenattribute should have a value. Usearia-hidden="true"instead of justaria-hidden.
src/routes/pages/personalInfo/settings.svelte:192 - [nitpick] Setting
href=""on a button element is unnecessary since the navigation is handled by theon:clickhandler. Consider removing thehrefattribute or usinghref="#"to maintain proper link semantics while preventing default navigation.
src/routes/pages/personalInfo/settings.svelte:192 - [nitpick] Missing space in event handler. Should be
on:click={() => { navController.push(Faq) }}with a space after the opening brace.
src/routes/pages/personalInfo/settings.svelte:192 - The
aria-hiddenattribute should have a value. Usearia-hidden="true"instead of justaria-hidden.
src/routes/pages/personalInfo/about.svelte:12 - [nitpick] Unused import. The
constructicon is imported but the code uses it directly as{construct}rather than from theallIonicIconsobject, which is inconsistent with how other icons are used in the file. Consider usingimport * as allIonicIcons from 'ionicons/icons'and accessing it asallIonicIcons.constructfor consistency.
src/routes/pages/personalInfo/settings.svelte:186 - [nitpick] Setting
href=""on a button element is unnecessary since the navigation is handled by theon:clickhandler. Consider removing thehrefattribute or usinghref="#"to maintain proper link semantics while preventing default navigation.
src/routes/pages/personalInfo/about.svelte:31 - Typo in comment: 'Suffle' should be 'Shuffle'.
src/lib/components/personalInfo/contributors.json:37 - Missing space after colon. Should be
"maintainer": falsefor consistent JSON formatting.
src/lib/components/personalInfo/contributors.json:49 - Missing space after colon. Should be
"maintainer": falsefor consistent JSON formatting.
src/routes/pages/personalInfo/settings.svelte:186 - [nitpick] Missing space in event handler. Should be
on:click={() => { navController.push(About) }}with a space after the opening brace.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #291 and #299