ci: upgrade lighthouse to v10
#641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hadn’t approved it because it was failing ci- Is it ok in this case? |
|
It was failing because of audit checks, which we want addressed but I'm not doing that in this PR and they're all sort of wrapped around each other - so landing this helps makes it a bit easier to address the security checks |
|
Oh yep I was mixing this one up with the one failing because of node versions, all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of lighthouse are always better and this helps ensure we can apply the latest security patches - we can't go any higher than v10 right now because v11 required Node v18 or higher but this is still an improvement and we plan to upgrade Node later this year