feat(@typescript-eslint): enable some new rules

ackama · Jul 14, 2023 · 6a3b751 · 6a3b751
1 parent f3b63ad
commit 6a3b751
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/@typescript-eslint.js b/@typescript-eslint.js
@@ -71,6 +71,8 @@ const config = {
     '@typescript-eslint/no-invalid-this': 'error',
     '@typescript-eslint/no-loop-func': 'error',
     '@typescript-eslint/no-meaningless-void-operator': 'error',
+    '@typescript-eslint/no-mixed-enums': 'error',
+    '@typescript-eslint/no-non-null-assertion': 'error',
     '@typescript-eslint/no-namespace': [
       'off', // todo: need to audit existing codebase to see if declare is fine
       {
@@ -102,6 +104,7 @@ const config = {
     '@typescript-eslint/prefer-ts-expect-error': 'error',
     '@typescript-eslint/promise-function-async': 'error',
     '@typescript-eslint/require-array-sort-compare': 'warn',
+    '@typescript-eslint/sort-type-constituents': 'error',
     '@typescript-eslint/switch-exhaustiveness-check': 'error',
     '@typescript-eslint/unified-signatures': 'warn', // can be a bit wrong
     'array-callback-return': 'off',

diff --git a/test/configs.spec.ts b/test/configs.spec.ts
@@ -42,7 +42,7 @@ const determinePluginPackageName = (plugin: string): string => {
 const requireConfig = (
   config: string
 ): ESLint.Linter.Config &
-  Required<Pick<ESLint.Linter.Config, 'plugins' | 'extends' | 'rules'>> => ({
+  Required<Pick<ESLint.Linter.Config, 'extends' | 'plugins' | 'rules'>> => ({
   plugins: [],
   extends: [],
   rules: {},
@@ -205,7 +205,8 @@ describe('for each config file', () => {
             config.parser
           );
           expect(packageJson.peerDependenciesMeta).toHaveProperty(
-            config.parser as string,
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+            config.parser!,
             { optional: true }
           );
         });