fix: correct mislabeled history entries and add undo for clip version switch by ChuxiJ · Pull Request #1387 · ace-step/ACE-Step-DAW

ChuxiJ · 2026-04-02T06:29:01Z

Summary

Fix freezeTrack, unfreezeTrack, and flattenTrack history labels — they were incorrectly labeled as audio effect operations (e.g., "Add audio effect" for freeze, "Remove audio effect" for flatten)
Add undo history entry for setActiveVersion — switching between clip versions is now undoable
Add regression tests for history labels and undo behavior

Context

Most acceptance criteria for #1357 were already implemented:

addTrack/removeTrack are undoable (181 _pushHistory calls in codebase)
Effect chain add/remove/edit are undoable
History capped at 50 entries per bucket
Undo History Panel accessible via Ctrl+Alt+Z

This PR fixes the remaining gaps: mislabeled entries and missing clip version switch undo.

Test Plan

All 3861 unit tests pass (4 new)
TypeScript compiles cleanly
Freeze/unfreeze/flatten history labels verified
setActiveVersion creates history entry and is reversible via undo

Closes #1357

🤖 Generated with Claude Code

… switch (#1357) - Fix freezeTrack/unfreezeTrack/flattenTrack history labels (were incorrectly labeled as audio effect operations, now correctly labeled) - Add undo history entry for setActiveVersion (switching clip versions is now undoable) - Add regression tests for history labels and undo behavior Note: Most acceptance criteria for #1357 were already implemented (181 _pushHistory calls, MAX_HISTORY=50 cap, Undo History Panel with Ctrl+Alt+Z). This PR fixes the remaining gaps: mislabeled entries and missing version switch undo. Closes #1357 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR improves the undo/history system in useProjectStore by correcting mislabeled history entries for track freeze operations and making clip version switching (setActiveVersion) undoable, with new unit tests to prevent regressions.

Changes:

Update freezeTrack, unfreezeTrack, and flattenTrack history entries to use arrangement scope with correct labels.
Add an undo history entry for setActiveVersion so clip version switching can be undone.
Add unit tests covering freeze/unfreeze history labels and clip version undo behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`src/store/projectStore.ts`	Fixes history labels/scope for freeze/unfreeze/flatten and adds history capture for `setActiveVersion`.
`tests/unit/trackFreeze.test.ts`	Adds regression tests asserting correct history labels/scope for freeze/unfreeze.
`tests/unit/clipVersionHistory.test.ts`	Adds tests ensuring `setActiveVersion` creates a history entry and is undoable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-02T06:34:42Z

tests/unit/clipVersionHistory.test.ts

+                  versions: [
+                    { cumulativeMixKey: 'v0', isolatedAudioKey: 'v0-iso', waveformPeaks: null, inferredMetas: null, generatedFromContext: false, serverCumulativePath: null },
+                    { cumulativeMixKey: 'v1', isolatedAudioKey: 'v1-iso', waveformPeaks: null, inferredMetas: null, generatedFromContext: false, serverCumulativePath: null },
+                  ],


The versions test fixtures don’t match the ClipVersion shape used in production: id and generatedAt are required, and optional fields like inferredMetas/serverCumulativePath should be omitted/undefined rather than null. Using null here can create states that never occur in real projects and can also lead to runtime issues (e.g., code that spreads clip.inferredMetas will throw if it’s null). Update the fixtures to use the real ClipVersion fields and avoid null for optional properties.

Copilot · 2026-04-02T06:34:42Z

tests/unit/clipVersionHistory.test.ts

+                  versions: [
+                    { cumulativeMixKey: 'v0', isolatedAudioKey: 'original-audio', waveformPeaks: null, inferredMetas: null, generatedFromContext: false, serverCumulativePath: null },
+                    { cumulativeMixKey: 'v1', isolatedAudioKey: 'new-audio', waveformPeaks: null, inferredMetas: null, generatedFromContext: false, serverCumulativePath: null },
+                  ],


Same as above: this ClipVersion fixture omits required fields (id, generatedAt) and uses null for optional properties. Aligning the fixture with the real ClipVersion interface will keep the test representative and avoid introducing invalid clip state during the test run.

Copilot · 2026-04-02T06:34:42Z

src/store/projectStore.ts

    const track = state.project.tracks.find((t) => t.id === trackId);
    if (!track) return;
-    _pushHistory(state.project, { scope: 'mixer', label: 'Remove audio effect', trackId });
+    _pushHistory(state.project, { scope: 'arrangement', label: 'Flatten track', trackId });



flattenTrack now writes a new history label/scope, but there’s no regression test coverage for it (only freeze/unfreeze are asserted). Add a unit test similar to the freeze/unfreeze history-label tests to ensure flattenTrack produces the expected arrangement history entry label going forward.

Copilot · 2026-04-02T06:34:43Z

src/store/projectStore.ts

    if (!state.project) return;
    const clip = state.project.tracks.flatMap((t) => t.clips).find((c) => c.id === clipId);
    if (!clip || !clip.versions || idx < 0 || idx >= clip.versions.length) return;
+    _pushHistory(state.project, { scope: 'arrangement', label: 'Switch clip version', clipId });



Now that setActiveVersion is explicitly undoable, it’s worth keeping the clip fields it writes aligned with the Clip/ClipVersion types. In particular, consider normalizing any null optional fields coming from persisted JSON (e.g., inferredMetas, serverCumulativePath) to undefined before writing them back onto the clip, since downstream code assumes these are objects/strings when present (e.g., spreading clip.inferredMetas).

…test - Fix ClipVersion test fixtures: add required id/generatedAt, use undefined for optional fields instead of null - Add flattenTrack history label regression test - Use typed makeVersion() helper for valid fixtures Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

ChuxiJ · 2026-04-02T08:33:16Z

All Copilot review feedback has been addressed in the latest commit. Key changes:

PR #1387:

Fixed ClipVersion test fixtures: added required id/generatedAt fields
Changed null to undefined for optional properties in fixtures
Added flattenTrack history label regression test

All tests pass. Ready for re-review.

… switch (#1387) * fix: correct mislabeled history entries and add undo for clip version switch (#1357) - Fix freezeTrack/unfreezeTrack/flattenTrack history labels (were incorrectly labeled as audio effect operations, now correctly labeled) - Add undo history entry for setActiveVersion (switching clip versions is now undoable) - Add regression tests for history labels and undo behavior Note: Most acceptance criteria for #1357 were already implemented (181 _pushHistory calls, MAX_HISTORY=50 cap, Undo History Panel with Ctrl+Alt+Z). This PR fixes the remaining gaps: mislabeled entries and missing version switch undo. Closes #1357 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address Copilot review — fix test fixtures and add flattenTrack test - Fix ClipVersion test fixtures: add required id/generatedAt, use undefined for optional fields instead of null - Add flattenTrack history label regression test - Use typed makeVersion() helper for valid fixtures Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings April 2, 2026 06:29

Copilot started reviewing on behalf of ChuxiJ April 2, 2026 06:29 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

ChuxiJ merged commit c65db5b into main Apr 2, 2026
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: correct mislabeled history entries and add undo for clip version switch#1387

fix: correct mislabeled history entries and add undo for clip version switch#1387
ChuxiJ merged 2 commits intomainfrom
fix/issue-1357

ChuxiJ commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

ChuxiJ commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ChuxiJ commented Apr 2, 2026

Summary

Context

Test Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

ChuxiJ commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants