Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jesswang-dev/i7/update feature icons #18

Merged

Conversation

jesswang-dev
Copy link
Contributor

@jesswang-dev jesswang-dev commented Aug 4, 2023

Closes #

Changes

  • updated docusaurus package to v2.4.1
  • changed icons in featureList into new svgs

Flags

Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for concerto-docs ready!

Name Link
🔨 Latest commit 72cd438
🔍 Latest deploy log https://app.netlify.com/sites/concerto-docs/deploys/64d1208481734100088e6d43
😎 Deploy Preview https://deploy-preview-18--concerto-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mttrbrts
Copy link
Member

mttrbrts commented Aug 7, 2023

A big improvement @jesswang-dev. Thank you!

Please click the Set DCO to pass button on this page, and I'll be happy to approve.
https://github.com/accordproject/concerto-docs/pull/18/checks?check_run_id=15635143581

@jesswang-dev jesswang-dev force-pushed the jesswang-dev/i7/update-feature-icons branch from 695d394 to 72cd438 Compare August 7, 2023 16:49
@jesswang-dev
Copy link
Contributor Author

jesswang-dev commented Aug 7, 2023

A big improvement @jesswang-dev. Thank you!

Please click the Set DCO to pass button on this page, and I'll be happy to approve. https://github.com/accordproject/concerto-docs/pull/18/checks?check_run_id=15635143581

Hi Matt! The signoff check has passed! Thank you!

@jesswang-dev jesswang-dev marked this pull request as ready for review August 11, 2023 20:58
@mttrbrts mttrbrts merged commit f466568 into accordproject:main Aug 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants